Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The all-contributors bot only partially recognizes the contribution types "infra" and "doc" #487

Open
jpivarski opened this issue Jan 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jpivarski
Copy link

jpivarski commented Jan 18, 2024

I used "infra" as the contribution name, following https://allcontributors.org/docs/en/emoji-key

scikit-hep/awkward#1224 (comment)

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

but in the pull request, the correct title, "Infrastructure (Hosting, Build-Tools, etc)", is added to the README.

https://github.com/scikit-hep/awkward/blob/fd53a67514f59c402566d926a9a56f87d90217bd/README.md?plain=1#L216

@jpivarski jpivarski added the bug Something isn't working label Jan 18, 2024
@jpivarski jpivarski changed the title The all-contributors bot only partially recognizes the contribution type "infra" The all-contributors bot only partially recognizes the contribution types "infra" and "doc" Jan 18, 2024
@jpivarski
Copy link
Author

Same thing for "doc":

scikit-hep/awkward#358 (comment)

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

but in the pull request, the correct title, "Documentation", is added to the README.

https://github.com/scikit-hep/awkward/blob/6bb9bc8c304908ba73b4de5b00e40d80a6c47b7a/README.md?plain=1#L221C319-L221C334

@jpivarski
Copy link
Author

Okay, this is weird: it said the same thing for "code". I probably use "code" more often than anything else. Maybe this message is always misleading, but the bot does the right thing.

scikit-hep/awkward#583 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant