Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full integration test using vercel dev or testing the actual preview deployment #384

Open
gr2m opened this issue Oct 21, 2021 · 2 comments
Open

Add full integration test using vercel dev or testing the actual preview deployment #384

gr2m opened this issue Oct 21, 2021 · 2 comments
Assignees
@tenshiAMD
Labels
enhancement New feature or request help wanted Extra attention is needed maintenance

Comments

@gr2m
Copy link
Contributor

gr2m commented Oct 21, 2021

I upgraded Probot to v12 via #381 which actually broke the app, without any tests failing. The problem is that we only testing the app by directly importing app.js. We should add at least one full integration test where we either start the server to with vercel dev and send a POST /api/github/webhooks request to the local server, or send the same request to the Vercel preview deployment, once it's ready. The former is easier, the latter is better.
@gr2m gr2m added enhancement New feature or request maintenance help wanted Extra attention is needed labels Oct 21, 2021
@tenshiAMD
Copy link
Member

@gr2m Can I give this a try?

@gr2m
Copy link
Contributor Author

gr2m commented Sep 8, 2022

All yours 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenshiAMD tenshiAMD

Labels
enhancement New feature or request help wanted Extra attention is needed maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gr2m @tenshiAMD