Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect filling of computation time into the msg_size of workloads in AIOB #22

Open
dageita opened this issue Dec 18, 2024 · 1 comment

Comments

@dageita
Copy link

dageita commented Dec 18, 2024

When running benchmark suites ./aicb.py, a csv workload will be generated.
The code for filling the generated computation time into the workload is as follows, which appears to be filled in the msg_size field of workload:

def Comp_with_aiob(workload, compute_cache):
    for item in workload.workload:
        if item.comm_type == CommType.computation:
            for key in compute_cache:
                key_temp = key.split("_")[0]
                if key_temp in item.stage:
                    item.msg_size = compute_cache[key]
                    break
    return workload

However, compute_cache is the extracted operator time, not msg_size, which seems contradictory:

workload = Comp_with_aiob(workload, compute_cache)
@Huoyuan100861
Copy link
Collaborator

When running benchmark suites ./aicb.py, a csv workload will be generated. The code for filling the generated computation time into the workload is as follows, which appears to be filled in the msg_size field of workload:

def Comp_with_aiob(workload, compute_cache):
    for item in workload.workload:
        if item.comm_type == CommType.computation:
            for key in compute_cache:
                key_temp = key.split("_")[0]
                if key_temp in item.stage:
                    item.msg_size = compute_cache[key]
                    break
    return workload

However, compute_cache is the extracted operator time, not msg_size, which seems contradictory:

workload = Comp_with_aiob(workload, compute_cache)

You've noticed a subtle detail indeed. There is a naming ambiguity where compute_cache actually refers to the operator execution time, not msg_size, which might be confusing.
Fortunately, this hasn't currently affected the overall functionality. We are reviewing the pull request you submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants