From 6e213cd2102db8bc4a1b887a75e9bde047dbab46 Mon Sep 17 00:00:00 2001
From: Giulio Eulisse <10544+ktf@users.noreply.github.com>
Date: Tue, 20 Aug 2024 16:28:40 +0200
Subject: [PATCH] Improve installation order (#1389)

In case we need to split the packages to be installed, always keep
the toplevel packages last, so that we do not risk
---
 publish/aliPublishS3 | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/publish/aliPublishS3 b/publish/aliPublishS3
index ed6821e6..51d1a678 100755
--- a/publish/aliPublishS3
+++ b/publish/aliPublishS3
@@ -688,6 +688,20 @@ def sync(pub, architectures, s3Client, bucket, baseUrl, basePrefix, rules,
       error("Too many packages to publish (%d); limiting to %d to avoid "
             "running out of temporary disk space",
             len(pubPackages), publishLimit)
+      # We make sure that if we split, O2Physics, O2 and other toplevel packages
+      # get installed last.
+      def custom_sort_key(s):
+        for l in ["Suite", "QualityControl", "AliGenerator"]:
+          if l in s:
+            return (3, s)
+        for l in ["O2Physics", "AliPhysics"]:
+          if l in s:
+            return (2, s)
+        for l in ["O2", "AliRoot"]:
+          if l in s:
+            return (1, s)
+        return (0, s)
+      pubPackages = sorted(pubPackages, key=custom_sort_key)
       pubPackages = pubPackages[:publishLimit]
 
     # Packages installation