From 366226a58db8ad60d6cf1dd778b4fe1c1ed8b913 Mon Sep 17 00:00:00 2001 From: Gowri Date: Thu, 5 Oct 2023 14:46:51 +1030 Subject: [PATCH] DO-1530: remove skip lib check and include DOM lib --- packages/esbuild/tsconfig.json | 5 ++++- tsconfig.json | 7 +------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/esbuild/tsconfig.json b/packages/esbuild/tsconfig.json index 4082f16a..99bd998d 100644 --- a/packages/esbuild/tsconfig.json +++ b/packages/esbuild/tsconfig.json @@ -1,3 +1,6 @@ { - "extends": "../../tsconfig.json" + "extends": "../../tsconfig.json", + "compilerOptions": { + "skipLibCheck": true + } } diff --git a/tsconfig.json b/tsconfig.json index 4119ec45..f2309643 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -2,7 +2,7 @@ "compilerOptions": { "target": "ES2018", "module": "commonjs", - "lib": ["es2018"], + "lib": ["es2018", "DOM"], "declaration": true, "strict": true, "noImplicitAny": true, @@ -19,11 +19,6 @@ "strictPropertyInitialization": false, "typeRoots": ["./node_modules/@types"], "types": ["node", "jest"], - - // https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/826 - // Ideally this should only be specified in packages/esbuild/tsconfig.json, however it doesn't seem to be - // loading that config file during build. - "skipLibCheck": true }, "exclude": ["**/node_modules", "cdk.out", "**/handlers/**"] }