Fix #72 #73
Closed
Fix #72 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keep the JARs open in the URLClassLoader until we're done with
building our delta model
- Then, explicitly cl.close() it when appropriate (???) to release the
JARs
|
WONTFIX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Windows-only issue:
.close()or the JVM diesMaracas.computeDelta(v1, v2))The current dirty workaround is to keep a reference to the classloader we pass to Spoon until we're done computing Spoon references for the delta model, and then explicitly
close()it. The current fix may affect the impact analysis: at the time we're computing the impact model, the JARs are now closed, so if we try to access some references that haven't been accessed before, they may fail.