Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Compatibility #77

Open
saadmanrafat opened this issue Oct 15, 2018 · 6 comments
Open

Windows Compatibility #77

saadmanrafat opened this issue Oct 15, 2018 · 6 comments
Labels
compatibility good first issue Good for newcomers help wanted Extra attention is needed

Comments

@saadmanrafat
Copy link

saadmanrafat commented Oct 15, 2018

I was wondering if this could be extended to work on Windows.

@alichtman
Copy link
Owner

alichtman commented Oct 15, 2018

Yeah, this isn't limited to just macOS, but it would require a bunch of refactoring and testing that just isn't a priority of mine since I don't use Windows. I'm definitely open to a PR, though.

@alichtman alichtman added help wanted Extra attention is needed feature New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 15, 2018
@alichtman alichtman changed the title Support For Windows? Windows Compatibility Oct 15, 2018
@alichtman
Copy link
Owner

Implementation Plan

  • Use os.path.join obsessively, for all paths

Is this it?

@saadmanrafat
Copy link
Author

Yes but another issue is inquirer, which doesn't work on Windows. Other viable choices are prompt_toolkit and Pyinquirer. Each has it's pros and cons. But using any one of them could lead to losing some features the repo already supports like the List prompt.

@alichtman
Copy link
Owner

alichtman commented Oct 18, 2018

One possibility is forking this project and maintaining a Windows version separately. I don't have the bandwidth to manage that, but I'd be open to someone else maintaining it.

@alichtman alichtman added compatibility and removed feature New feature or request labels Oct 19, 2018
@alichtman
Copy link
Owner

Another possibility is try / except importing inquirer and if that fails, import some other library that's Windows compatible. This is probably the best solution, as it would avoid forking the project. I still don't use Windows, though, so I won't be fixing this.

@saadmanrafat
Copy link
Author

try except might work. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants