change threshold for sfm validity #1760
Open
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servantftechnicolor
force-pushed
the
dev/thresholdSfm
branch
from
b966d25 to
834237b
Compare
cbentejac
force-pushed
the
dev/thresholdSfm
branch
from
834237b to
4ab99b4
Compare
simogasp
requested changes
Nov 5, 2024
| int nbposes = _sfmData.getPoses().size(); | ||
|
|
||
| int minPoses = 1; | ||
| if (nbviews > 5) |
There was a problem hiding this comment.
I would a new param to the set of parameters of the class
(with a line of comment that explains the meaning)
Not necessary that it is exposed, but it's better than having a random number in the code.
Comment on lines
+230
to
+239
| int nbviews = _sfmData.getViews().size(); | ||
| int nbposes = _sfmData.getPoses().size(); | ||
|
|
||
| int minPoses = 1; | ||
| if (nbviews > 5) | ||
| { | ||
| minPoses = 3; | ||
| } | ||
|
|
||
| return (nbposes >= minPoses); |
There was a problem hiding this comment.
Suggested change
| int nbviews = _sfmData.getViews().size(); | |
| int nbposes = _sfmData.getPoses().size(); | |
| int minPoses = 1; | |
| if (nbviews > 5) | |
| { | |
| minPoses = 3; | |
| } | |
| return (nbposes >= minPoses); | |
| const auto nbviews = _sfmData.getViews().size(); | |
| const auto nbposes = _sfmData.getPoses().size(); | |
| const std::size_t minPoses = nbviews > small_dataset? 3 : 1; | |
| return (nbposes >= minPoses); |
where small_dataset is the placeholder for the new param discussed above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, sfm returns an error only if there is no reconstructed views.
We want to return an error if there is only the initial reconstructed pair and no other valid views.
If the number of views is small, we still keep 1 view as the minimal size, but for any other size, we also return an error if only 2 views are reconstructed.