Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sfm] statistics: fix statistics to avoid troubles in particular cases #1688

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[sfm] statistics: fix statistics to avoid troubles in particular cases #1688

wants to merge 2 commits into from
+10 −10

Conversation

fabiencastan
Copy link
Member

In particular configuration, like a failed resection, we may end-up with unexpected statistics.
Put some limits to avoid that.

@fabiencastan fabiencastan added this to the 3.3.0 milestone Mar 24, 2024
servantftechnicolor
servantftechnicolor reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@servantftechnicolor servantftechnicolor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the outStats.max values are not checked for a value of 0, which may create a +inf result in histogram constructor. Although this is not realistic, this may happen in tests and also (rarely) in "computeScaleHistogram".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@servantftechnicolor servantftechnicolor servantftechnicolor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fabiencastan @servantftechnicolor