Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

请问sandbox可以支持用户自定添加transformer吗 #411

Open
lossend opened this issue Feb 9, 2023 · 7 comments
Open

请问sandbox可以支持用户自定添加transformer吗 #411

lossend opened this issue Feb 9, 2023 · 7 comments

Comments

@lossend
Copy link

lossend commented Feb 9, 2023

No description provided.

@lossend lossend changed the title 请问sandbox可以支持用户自定添加transform吗 请问sandbox可以支持用户自定添加transformer吗 Feb 9, 2023
@oldmanpushcart
Copy link
Collaborator

回答问题:没有
问题解析:有过这个PR但最终内部投票投死了。添加自定义的transformer和AOP的初衷相违背了,把自己往ByteBuddy上靠。

如果你真需要做这种个性化的定制,这个项目也是开源的,可以考虑fork自己修改。不过我认为ByteBuddy可能会是你更好的选择。

@lossend
Copy link
Author

lossend commented Feb 9, 2023

好的多谢,另外问下sandbox有对threadlocal父子线程传递的方案吗,特别是forkjoin场景,似乎只用aop好像不能实现吧?

@lossend
Copy link
Author

lossend commented Feb 9, 2023

使用ttl的agent又似乎要多引入一个agent

@oldmanpushcart
Copy link
Collaborator

线程间上下文传递和AOP无关,主要出现是一些代码调用联跟踪的场景,不支持的原因还是想尽量保证sandbox功能的纯粹。我们实际写的时候的确会有遇到类似的问题,我的常规处理做法是用一个全局的WeakMap来解决此事,KEY选择是一个能串联业务的参数,比如订单ID。

@lossend
Copy link
Author

lossend commented Mar 10, 2023 via email

@oldmanpushcart
Copy link
Collaborator

我考虑下,直接支持掉内部线程的场景。思路也是有的

@lossend
Copy link
Author

lossend commented Mar 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants