Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The return value of 'sscanf()' should be checked #5

Open
QiAnXinCodeSafe opened this issue Nov 27, 2019 · 0 comments
Open

The return value of 'sscanf()' should be checked #5

QiAnXinCodeSafe opened this issue Nov 27, 2019 · 0 comments
Labels
minor Something that is not critical

Comments

@QiAnXinCodeSafe
Copy link

cloud-kernel/tools/power/x86/intel-speed-select/isst-config.c

Line 1344 in c154e18

sscanf(optarg, "0x%llx", &fact_trl);

@casparant casparant added the minor Something that is not critical label Nov 27, 2019
casparant pushed a commit that referenced this issue Sep 1, 2020
@lostjeffle
ext4: fix a data race in EXT4_I(inode)->i_disksize
ff11a02 
task #28557685

commit 35df429 upstream.

EXT4_I(inode)->i_disksize could be accessed concurrently as noticed by
KCSAN,

 BUG: KCSAN: data-race in ext4_write_end [ext4] / ext4_writepages [ext4]

 write to 0xffff91c6713b00f8 of 8 bytes by task 49268 on cpu 127:
  ext4_write_end+0x4e3/0x750 [ext4]
  ext4_update_i_disksize at fs/ext4/ext4.h:3032
  (inlined by) ext4_update_inode_size at fs/ext4/ext4.h:3046
  (inlined by) ext4_write_end at fs/ext4/inode.c:1287
  generic_perform_write+0x208/0x2a0
  ext4_buffered_write_iter+0x11f/0x210 [ext4]
  ext4_file_write_iter+0xce/0x9e0 [ext4]
  new_sync_write+0x29c/0x3b0
  __vfs_write+0x92/0xa0
  vfs_write+0x103/0x260
  ksys_write+0x9d/0x130
  __x64_sys_write+0x4c/0x60
  do_syscall_64+0x91/0xb47
  entry_SYSCALL_64_after_hwframe+0x49/0xbe

 read to 0xffff91c6713b00f8 of 8 bytes by task 24872 on cpu 37:
  ext4_writepages+0x10ac/0x1d00 [ext4]
  mpage_map_and_submit_extent at fs/ext4/inode.c:2468
  (inlined by) ext4_writepages at fs/ext4/inode.c:2772
  do_writepages+0x5e/0x130
  __writeback_single_inode+0xeb/0xb20
  writeback_sb_inodes+0x429/0x900
  __writeback_inodes_wb+0xc4/0x150
  wb_writeback+0x4bd/0x870
  wb_workfn+0x6b4/0x960
  process_one_work+0x54c/0xbe0
  worker_thread+0x80/0x650
  kthread+0x1e0/0x200
  ret_from_fork+0x27/0x50

 Reported by Kernel Concurrency Sanitizer on:
 CPU: 37 PID: 24872 Comm: kworker/u261:2 Tainted: G        W  O L 5.5.0-next-20200204+ #5
 Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019
 Workqueue: writeback wb_workfn (flush-7:0)

Since only the read is operating as lockless (outside of the
"i_data_sem"), load tearing could introduce a logic bug. Fix it by
adding READ_ONCE() for the read and WRITE_ONCE() for the write.

Signed-off-by: Qian Cai <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Jeffle Xu <[email protected]>
Acked-by: Joseph Qi <[email protected]>
shiloong pushed a commit that referenced this issue Jan 12, 2022
@ozbenh @shiloong
PCI/ACPI: Evaluate PCI Boot Configuration _DSM
697a866 
ANBZ: #43

commit a78cf96 upstream

Evaluate _DSM Function #5, the "PCI Boot Configuration" function.  If the
result is 0, the OS should preserve any resource assignments made by the
firmware.

[
  Guanjun: fix conflicts in
    include/linux/pci.h
]

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <[email protected]>
Signed-off-by: Guanjun <[email protected]>
Reviewed-by: Zelin Deng <[email protected]>
shiloong pushed a commit that referenced this issue Apr 2, 2022
@ozbenh @shiloong
PCI/ACPI: Evaluate PCI Boot Configuration _DSM
849bfd8 
ANBZ: #43

commit a78cf96 upstream

Evaluate _DSM Function #5, the "PCI Boot Configuration" function.  If the
result is 0, the OS should preserve any resource assignments made by the
firmware.

[
  Guanjun: fix conflicts in
    include/linux/pci.h
]

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <[email protected]>
Signed-off-by: Guanjun <[email protected]>
Reviewed-by: Zelin Deng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor Something that is not critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@casparant @QiAnXinCodeSafe