Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow /local/path for *_URL parameters within config file #159

Open
ryanRfox opened this issue Nov 22, 2022 · 0 comments
Open

Allow /local/path for *_URL parameters within config file #159

ryanRfox opened this issue Nov 22, 2022 · 0 comments
Labels
new-feature-request Feature request that needs triage Team Lamprey

Comments

@ryanRfox
Copy link
Contributor

Problem

As a dev I may frequently modify go-algorand or indexer code on my local file system. I don't want to push to GitHub each change prior to testing the build using sandbox. Currently, supplying /path/to/my/repo for ALGOD_URL field within my.config configuration file results in the error "fatal: /path/to/my/repo does not exist". I'll make the assumption the INDEXER_URL behaves similarly.

Solution

Proposed by @joe-p:

  1. Comment out this line:
    git clone --single-branch --branch "${BRANCH}" "${URL}"
git clone --single-branch --branch "${BRANCH}" "${URL}"
  1. Then add a COPY command similar to this line that copies in the repo to the container:
    COPY . /tmp
COPY . /tmp
  1. investigate/modify for indexer as well.

  2. Solution should parse the URL field value and switch based on the source.

Dependencies

None known.

Urgency

Nice to have.

h/t @riolavigne

@ryanRfox ryanRfox added the new-feature-request Feature request that needs triage label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature-request Feature request that needs triage Team Lamprey
Projects
None yet
Development

No branches or pull requests

2 participants