Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval: add DetailedEvalErrors method to EvalTracer interface #6172

Merged

Conversation

cce
Copy link
Contributor

@cce cce commented Nov 16, 2024

Summary

In #6170 and #6171 the EvalError details were removed to avoid unnecessary disassembly for error messages. This adds a method to the EvalTracer interface to allow certain use cases (unit tests, DeveloperAPI enabled) to request the additional detail.

Test Plan

Old versions of unit tests asserting specific opcodes in EvalError messages should work again in this PR.

@cce cce requested review from jannotti and algorandskiy and removed request for jannotti November 18, 2024 15:08
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.25%. Comparing base (64dc085) to head (4762181).
Report is 1 commits behind head on experimental-tweaks.

Files with missing lines Patch % Lines
data/pools/transactionPool.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           experimental-tweaks    #6172      +/-   ##
=======================================================
- Coverage                56.26%   56.25%   -0.01%     
=======================================================
  Files                      494      494              
  Lines                    69964    69976      +12     
=======================================================
+ Hits                     39366    39368       +2     
- Misses                   27915    27924       +9     
- Partials                  2683     2684       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@algorandskiy algorandskiy merged commit cc7f887 into algorand:experimental-tweaks Nov 18, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants