Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: do not report extra details for failed app txns #6171

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

algorandskiy
Copy link
Contributor

Summary

  1. Disable expensive error details on app txn failure
  2. Allow ERL to kick-in earlier if backlog gets congested
  3. Allow ARL to count all transactions, not only post ERL (controller by TxBacklogAppRateLimitingCountERLDrops)
  4. Set MaxConnectionsPerIP to 8 instead of 15

Test Plan

Existing tests

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.89%. Comparing base (7d4e23b) to head (ef6862d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
data/txHandler.go 50.00% 3 Missing and 1 partial ⚠️
data/pools/transactionPool.go 33.33% 1 Missing and 1 partial ⚠️
util/rateLimit.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6171      +/-   ##
==========================================
+ Coverage   51.86%   51.89%   +0.03%     
==========================================
  Files         639      639              
  Lines       85435    85454      +19     
==========================================
+ Hits        44309    44345      +36     
+ Misses      38324    38305      -19     
- Partials     2802     2804       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

ledger/boxtxn_test.go Outdated Show resolved Hide resolved
ledger/apptxn_test.go Outdated Show resolved Hide resolved
@gmalouf gmalouf self-requested a review November 18, 2024 16:18
gmalouf
gmalouf previously approved these changes Nov 18, 2024
Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the handful of questions I added.

@algorandskiy
Copy link
Contributor Author

Merged master in

@algorandskiy algorandskiy merged commit e97beee into master Nov 18, 2024
22 checks passed
algorandskiy added a commit to algorandskiy/go-algorand that referenced this pull request Nov 19, 2024
* algorand#6171 decreased MaxConnectionsPerIP default value and it is not
  enough for agreement/gossip tests
@gmalouf gmalouf deleted the experimental-tweaks branch November 20, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants