-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performance: do not report extra details for failed app txns #6171
Conversation
Set MaxConnectionsPerIP to 4, ERL should kick in when it hits the `backlogCongestionThreshold`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6171 +/- ##
==========================================
+ Coverage 51.86% 51.89% +0.03%
==========================================
Files 639 639
Lines 85435 85454 +19
==========================================
+ Hits 44309 44345 +36
+ Misses 38324 38305 -19
- Partials 2802 2804 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending the handful of questions I added.
Merged master in |
* algorand#6171 decreased MaxConnectionsPerIP default value and it is not enough for agreement/gossip tests
Summary
TxBacklogAppRateLimitingCountERLDrops
)MaxConnectionsPerIP
to 8 instead of 15Test Plan
Existing tests