Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: Make p2p listen address configurable via config.NetAddress #5721

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

iansuvak
Copy link
Contributor

Summary

Make P2P listenAddress and more importantly the port configurable via config.NetAddress. This is required for algonet functioning to make sure that the services start using expected ports.

Test Plan

Added a new test and existing tests should pass

@iansuvak iansuvak added Enhancement Team Carbon-11 p2p Work related to the p2p project labels Aug 31, 2023
@iansuvak iansuvak self-assigned this Aug 31, 2023
network/p2p/p2p.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #5721 (77a038a) into master (b0cf5c8) will increase coverage by 1.24%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##           master    #5721      +/-   ##
==========================================
+ Coverage   54.31%   55.56%   +1.24%     
==========================================
  Files         474      474              
  Lines       66416    66432      +16     
==========================================
+ Hits        36075    36912     +837     
+ Misses      27839    27020     -819     
+ Partials     2502     2500       -2     
Files Changed Coverage Δ
network/p2p/p2p.go 12.98% <58.82%> (+12.98%) ⬆️

... and 80 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iansuvak iansuvak requested a review from shiqizng September 1, 2023 14:12
@algorandskiy algorandskiy merged commit caf472a into algorand:master Sep 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement p2p Work related to the p2p project Team Carbon-11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants