Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rendering): ensure resilience against "null" results #6442

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(rendering): ensure resilience against "null" results #6442

wants to merge 4 commits into from

Commits on Nov 19, 2024

  1. fix(rendering): ensure resilience against "null" results 

    In some cases `results` in `render` can be null:
- no index name passed
- stalled render

In the vast majority of cases we already handled `results` being `null` or `undefined` just in case, but now i've changed the type to ensure we always catch this problem

This issue doesn't have a reproduction, but i believe it now guards for all possible cases of "no results", so:
fixes #6441

[CR-7353]
    @Haroenv
    Haroenv committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    094ae4f View commit details
    Browse the repository at this point in the history

  2. type

    @Haroenv
    Haroenv committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    caa00b2 View commit details
    Browse the repository at this point in the history

  3. types

    @Haroenv
    Haroenv committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6ca1dcd View commit details
    Browse the repository at this point in the history

  4. margin

    @Haroenv
    Haroenv committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2cd1ddc View commit details
    Browse the repository at this point in the history