Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When selecting characters in Chinese and Japanese IME, the search function may be triggered incorrectly. #2111

Open
PhantasWeng opened this issue Oct 31, 2023 · 8 comments

Comments

@PhantasWeng
Copy link

PhantasWeng commented Oct 31, 2023

Description

In Chinese and Japanese input methods, character selection is done using pinyin and enter key.

For example: to input "你" (ㄋ一ˇ), you would type ㄋ + ㄧ + ˇ + enter to select the character.
Currently, pressing enter triggers an incorrect input.

This results in submitting ㄋ一ˇ instead of .

Steps to reproduce

  1. Go to DocSearchModal > input
  2. Keypress on ㄋ一ˇ enter (key mapping to su3 enter)
  3. Expected to be a character selection, but turned into link selection.

Google Chrome 個人資料  OwlPay Documentation 2023-10-31 at 13 22 48

Expected behavior

Expected to be a character selection on first enter keypress.

For example, in chrome url input
Google Chrome When selecting characters in Chinese and Japanese IME the search function may be triggered incorrectly  · Issue #2111 · algoliadocsearch 2023-10-31 at 13 30 11

In github text area
Google Chrome When selecting characters in Chinese and Japanese IME the search function may be triggered incorrectly  · Issue #2111 · algoliadocsearch 2023-10-31 at 13 31 12

Environment

  • OS: [e.g. macOS]
  • Browser: [e.g. Chrome]
  • DocSearch version: Algolia DocSearch for docusaurus
@PhantasWeng
Copy link
Author

Any suggestions?

@randombeeper
Copy link
Collaborator

@PhantasWeng sorry for the delayed response, I'm trying to clean up our issues now. Is this still an open topic? I would expect this to be a general issue with the Autocomplete UI and not limited to Docusaurus. May I ask you test the behavior on other DocSearch (Autocomplete UI) sites? See here for some featured partners: https://docsearch.algolia.com/. For example, neither Bootstrap nor Material use Docusaurus.

@PhantasWeng
Copy link
Author

@randombeeper Yes, this issue still exists.

I encounter the same problem in different environments, which is why I am raising this issue here instead of on Docusaurus.

@PhantasWeng
Copy link
Author

Hi @randombeeper,

Here is a reference regarding events related to non-Latin IME:
Composition Event

For non-Latin IME, such as Chinese and Japanese, we typically use compositionstart and compositionend to determine input.

You can trigger the input change event using compositionend instead.

Could you let me know which file contains the program that triggers the event? I believe I could also contribute.

@Jorrrmungandr
Copy link

I also encountered the same problem in Vue.js doc. But it works fine in Docsearch doc. I guess this problem has been fixed in a recent release?

@CritasWang

This comment was marked as outdated.

@CritasWang
Copy link

It seems to have been fixed in version 3.8

@CritasWang
Copy link

@algolia/autocomplete
This component added processing for Composition in version 1.15.1, while the previous version of docsearch did not update dependencies. The 3.8 version has updated dependencies, and the Chinese and Japanese input experience is very good after the dependencies are updated
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants