Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Server Error when using the plugin on a Netlify build that has a subdomain too long #859

Open
Fluf22 opened this issue Apr 10, 2024 · 0 comments

Comments

@Fluf22
Copy link

Fluf22 commented Apr 10, 2024

Per the RFC, each part of a FQDN must not have a length that goes over 63 octets (usually means 63 characters).
This means a Netlify user must not deploy from a branch whose name length is over 56 characters: https://answers.netlify.com/t/branch-deploy-failing-to-use-branchname-for-url/12396/2

A user had this issue. We could add a check in the plugin for the length of each part of the deployPrimeUrl to avoid getting a 500.
Also we could do it on the backend and return an explicit error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant