Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gflownet/gflownet.py - should not store self.env as well as self.env_maker #301

Open
josephdviviano opened this issue Apr 3, 2024 · 0 comments
Open

gflownet/gflownet.py - should not store self.env as well as self.env_maker #301

josephdviviano opened this issue Apr 3, 2024 · 0 comments
Assignees
@josephdviviano @alexhernandezgarcia
Labels
enhancement New feature or request

Comments

@josephdviviano
Copy link
Collaborator

currently, self.env is stored in the GFlowNet class, because other classes expect an env instance (to access various methods / attributes).

Since the gflownet now stores a class factory rather than a class instance, we should figure out another way to communicate with these other classes (instead of storing an env instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephdviviano josephdviviano

@alexhernandezgarcia alexhernandezgarcia

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephdviviano @alexhernandezgarcia