Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_rewards vs. get_terminating_rewards in Batch #254

Open
alexhernandezgarcia opened this issue Nov 27, 2023 · 0 comments
Open

get_rewards vs. get_terminating_rewards in Batch #254

alexhernandezgarcia opened this issue Nov 27, 2023 · 0 comments
Assignees
@alexhernandezgarcia

Comments

@alexhernandezgarcia
Copy link
Owner

It may be possible to get rid of get_rewards() altogether since it is probably used by the flow matching loss only and it does not need to get the 0s of the non-terminating states.
@alexhernandezgarcia alexhernandezgarcia self-assigned this Nov 27, 2023
alexhernandezgarcia added a commit that referenced this issue Dec 26, 2023
@alexhernandezgarcia
Merge pull request #271 from alexhernandezgarcia/fix-merge-losses
8c13f6d 
Fix issues from merge of PR #254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexhernandezgarcia alexhernandezgarcia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexhernandezgarcia