Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we care about unsaved changes when trying to close the program, not just tabs? #109

Open
tuna-salad opened this issue Apr 14, 2013 · 8 comments

Comments

@tuna-salad
Copy link

No description provided.

@dbozgoren
Copy link
Collaborator

we could just put a are you sure popup

On Sat, Apr 13, 2013 at 9:45 PM, Visit P. [email protected]
wrote:


Reply to this email directly or view it on GitHub:
#109

@gdmodica
Copy link
Collaborator

NO POPUPS!! Marty doesn't like them.

-David Modica
   Class of 2015
   Computer Science
   Alpha Phi Omega

From: dbozgoren [[email protected]]
Sent: Saturday, April 13, 2013 10:01 PM
To: alexhenning/wpi-suite-tng
Subject: Re: [wpi-suite-tng] Should we care about unsaved changes when trying to close the program, not just tabs? (#109)

we could just put a are you sure popup

On Sat, Apr 13, 2013 at 9:45 PM, Visit P. [email protected]
wrote:


Reply to this email directly or view it on GitHub:
#109


Reply to this email directly or view it on GitHubhttps://github.com//issues/109#issuecomment-16344499.

@tuna-salad
Copy link
Author

@gdmodica I think that pop-ups are appropriate for this kind of actions. We don't want users to lose information or unsaved changes, so we have to warn them more seriously than when they try to update with invalid values.

@gdmodica
Copy link
Collaborator

Looking through at it again, you are right, that is the right thing to use in this case. My apologies.

-David Modica
   Class of 2015
   Computer Science
   Alpha Phi Omega

From: Visit P. [[email protected]]
Sent: Saturday, April 13, 2013 10:38 PM
To: alexhenning/wpi-suite-tng
Cc: Modica, Glen David
Subject: Re: [wpi-suite-tng] Should we care about unsaved changes when trying to close the program, not just tabs? (#109)

@gdmodicahttps://github.com/gdmodica I think that pop-ups are appropriate for this kind of actions. We don't want users to lose information or unsaved changes, so we have to warn them more seriously than when they try to update with invalid values.


Reply to this email directly or view it on GitHubhttps://github.com//issues/109#issuecomment-16344866.

@ghost ghost assigned ctmanuel Apr 17, 2013
@tmdefreitas
Copy link

Have we reached a consensus on this question? Pop ups or no?

@jbmorse
Copy link
Collaborator

jbmorse commented Apr 24, 2013

Popups are a good idea for this type of thing

@jbmorse
Copy link
Collaborator

jbmorse commented Apr 24, 2013

Also I think we should ask the user if they want to close the window, regardless of whether or not changes were made. This will ensure that the user will not accidentally close it and get upset.

@gdmodica
Copy link
Collaborator

Ask Marty about that last one; we could say that it is a contract thing otherwise. I like the idea, but we don't want more popups if at all possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants