You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Comparing the changes, I have no idea why these two versions would behave differently.
I think this is actually a symptom of a deficiency in Cargo (compiletest_rs probably needs to do more to workaround it, I don't know if it's fixable in Cargo itself). compiletest_rs v0.3.8 moved from rustc-serialize to serde for serialization, serde_derive depends on syn = { version = "0.12", features = ["visit"] }, futures-await-async-macro depends on syn = { version = "0.12", default-features = false, features = ["full", "fold", "parsing", "printing", "extra-traits"] }. So when building futures-await via cargo test and when building via cargo test --manifest-path testcrate/Cargo.toml the syn dependency is being built with 2 different sets of feature flags, this ripples up the dependency tree and results in two different copies of futures-await being built for these two cases. compiletest_rs then doesn't know which copy is the one it should be testing and fails.
For some reason after #73 running
cargo test && cargo test --manifest-path testcrate/Cargo.toml
fails with a lot of error messages like:I applied a workaround for this on CI in #80: https://github.com/alexcrichton/futures-await/commits/c5b06c84b6545870fd4ac2d58a997aabb8a28b3e, but it would be nice to not have to build the whole dependency tree twice, and doesn't solve the issue for developers testing locally that don't know that it is required.
Appears to be related to Manishearth/compiletest-rs#101, opening an issue here so the workaround can be removed once upstream is fixed.
The text was updated successfully, but these errors were encountered: