Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versions with no actual diffs mess with history #356

Open
petiepooo opened this issue Aug 13, 2018 · 0 comments
Open

versions with no actual diffs mess with history #356

petiepooo opened this issue Aug 13, 2018 · 0 comments

Comments

@petiepooo
Copy link

steps to reproduce:

  1. Create a new article with reference content
  2. update once with a content change and a change comment (for reference)
  3. update article again, but with no change in content, only a change comment.
  4. view history (only see versions 1 and 2, no version 3)
  5. view article (version 3 exists only in kb_articles table, not in kb_article_versions)
  6. update again with content and change comment
  7. view history (only see versions 1, 2, and 4)
  8. kb_article_versions table does not have version 3 or its change comment

Users should be creating comments, not entering version change comments, if they are not changing the article's content, but this still doesn't seem like correct behavior. Should the update be rejected if there is no change to the article's content?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant