From 65ec3bd2424f419044e3f951268f35f433c4a579 Mon Sep 17 00:00:00 2001 From: Kevin Oberlies Date: Mon, 18 Nov 2024 08:48:15 -0800 Subject: [PATCH] ci: Fix lint errors due to mypy with python 3.12 (#1890) * ci: Fix lint errors. Now that we're using python 3.12 for the `lint` github action, we need to fix the errors that it is reporting. * fix: Pin `aiohttp` to fix lint error Also reorganize the transitive dependencies in pyproject.toml * fix: downgrade aiohttp because of python 3.8 support * fix: Add `type: ignore` back, until we drop support for python 3.8 * Pin at 3.10.11 instead of 3.10.8 * Remove ignore again --------- Co-authored-by: Grzegorz Banasiak --- esrally/client/asynchronous.py | 2 +- pyproject.toml | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/esrally/client/asynchronous.py b/esrally/client/asynchronous.py index 9c32efc44..76b18da84 100644 --- a/esrally/client/asynchronous.py +++ b/esrally/client/asynchronous.py @@ -77,7 +77,7 @@ async def send(self, conn: "Connection") -> "ClientResponse": self.response = self.response_class( self.method, self.original_url, - writer=self._writer, # type: ignore[arg-type] # TODO remove this ignore when introducing type hints + writer=self._writer, continue100=self._continue, timer=self._timer, request_info=self.request_info, diff --git a/pyproject.toml b/pyproject.toml index 557c6b986..d80b854c0 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -41,13 +41,12 @@ classifiers = [ ################################################################################################ dependencies = [ # License: Apache 2.0 - # transitive dependencies: - # urllib3: MIT - # aiohttp: Apache 2.0 - "elasticsearch[async]==8.6.1", "elastic-transport==8.4.1", + # License: MIT "urllib3==1.26.19", + # License: Apache 2.0 + "aiohttp==3.10.11", "docker==6.0.0", # avoid specific requests version to fix bug in docker-py "requests<2.32.0",