Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sim] Move pending base fee estimation to FeeEstimator from provider #825

Open
dancoombs opened this issue Oct 3, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dancoombs
Copy link
Collaborator

Describe the feature
Chains are inconsistent in how they expose the pending base fee via their RPCs. See #821.

To handle this, we should implement base fee oracles (similar to our priority fee oracles) that use different RPC methods based on the chain. This oracle can be chosen via ChainSpec.

Known implementations needed:

  • FeeHistory (default) - use eth_feeHistory and Alloy's FeeHistory::next_block_base_fee
  • Constant - Provide a constant base fee (use for Flow)
  • BaseFee - use eth_baseFee (use for Avalanche)
@dancoombs dancoombs added the enhancement New feature or request label Oct 3, 2024
@dancoombs dancoombs added this to the v0.4 milestone Oct 3, 2024
@dancoombs dancoombs self-assigned this Oct 3, 2024
@dancoombs dancoombs removed their assignment Oct 3, 2024
@dancoombs dancoombs modified the milestones: v0.4, v0.5 Oct 3, 2024
@dancoombs dancoombs self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
@dancoombs and others