chore: add example app to rn-base #1171
Conversation
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
gotta remerge this because the history got messed up |
| useEffect(() => { | ||
| // get the user if already logged in | ||
| signer.getAuthDetails().then(setUser); | ||
| }, []); |
There was a problem hiding this comment.
React Hook useEffect has a missing dependency: 'signer'. Either include it or remove the dependency array.
| const subscription = Linking.addEventListener("url", handleIncomingURL); | ||
|
|
||
| return () => subscription.remove(); | ||
| }, []); |
There was a problem hiding this comment.
React Hook useEffect has a missing dependency: 'handleIncomingURL'. Either include it or remove the dependency array.
* fix: fix linting and spacing issues * feat: remove package hoisting from example project * fix: fix linting and spacing issues * feat: add signer authentication sample implementation in example app * feat: add tsx to handle server instantiation * feat: update peer-dependencies for signer package --------- Co-authored-by: Iyk Azorji <[email protected]>
PR-Codex overview
This PR focuses on updating the
@account-kit/react-native-signerlibrary by modifying exports, enhancing server capabilities, and refactoring client-side code for improved navigation and session management.Detailed summary
RNSignerClienttoRNAlchemySignerinindex.tsx.redirect-server/index.tsfor handling redirects.MainActivity.ktto supportreact-native-screens.manager.tsto include error handling.package.jsonscripts to include a server start command.App.tsxusing@react-navigation/native.HomeScreen.tsxfor user authentication and display.AndroidManifest.xmlto include new intent filters.package.jsonfor compatibility.