PS-670-rendition-video_enhance3 #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4rthem
requested changes
Nov 28, 2024
lib/php/rendition-factory/src/DTO/BuildConfig/Transformation.php
Outdated
Show resolved
Hide resolved
lib/php/rendition-factory/src/Transformer/Video/VideoToAnimationTransformerModule.php
Outdated
Show resolved
Hide resolved
lib/php/rendition-factory/src/Transformer/Video/VideoToAnimationTransformerModule.php
Outdated
Show resolved
Hide resolved
lib/php/rendition-factory/src/Transformer/VoidTransformerModule.php
Outdated
Show resolved
Hide resolved
lib/php/rendition-factory/src/Transformer/VoidTransformerModule.php
Outdated
Show resolved
Hide resolved
jygaulier
force-pushed
the
PS-670-rendition-video_enhance3
branch
2 times, most recently
from
f10f4c9 to
d7da0de
Compare
4rthem
requested changes
Dec 4, 2024
databox/api/src/Validator/ValidRenditionDefinitionConstraint.php
Outdated
Show resolved
Hide resolved
- auto doc WIP
- more "twigable" options + factorization
- almost every "time" options supports float (2.5) or timecode ("00.00.02.50")
- video-summary module can generate "phraseanet" animated gif
- period sets the gap between frames from the _input video_, e.g. `"{{ input.duration/10 }}"` -> 10 frames extracted.
- duration sets the duration in seconds of each frame into the _output animated gif_, e.g. `0.1` -> 10 frames / seconds.
- video-summary module supports `start`
- ffmpeg module can extract audio: set `format: "audio-wav"` or `audio-mp3`, `audio-aac` ; todo: audio options
- ffmpeg module / filter "watermark" supports `path: <url>`
- bypass ffmpeg bugs (timecode / seconds)
- fix attributes access in twig : use `"{{ attr.myfield }}"` where `myfield` is the *slugified* attribute name
…e configuration file. mandatory documentation for all modules. refacto.
… module. move conf validator to attribute (not full entity)
jygaulier
force-pushed
the
PS-670-rendition-video_enhance3
branch
from
d7da0de to
1d69779
Compare
4rthem
requested changes
Dec 6, 2024
lib/php/rendition-factory-bundle/Resources/config/services.yaml
Outdated
Show resolved
Hide resolved
lib/php/rendition-factory/src/Command/ConfigurationValidateCommand.php
Outdated
Show resolved
Hide resolved
4rthem
approved these changes
Dec 9, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new cli
alchemy:rendition-factory:configto generate doc or validate configuration file.