Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
4rthem committed Dec 10, 2024
1 parent e6204f7 commit 00e054e
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 4 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ jobs:
target: keycloak
secrets: inherit

build_novu-bridge:
name: 'Build novu-bridge'
uses: ./.github/workflows/build_base.yaml
with:
image: novu-bridge
context: ./novu/bridge
secrets: inherit

build_php-fpm-base:
name: 'Build php-fpm-base'
uses: ./.github/workflows/build_base.yaml
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1190,7 +1190,7 @@ services:
- "traefik.enable=true"
- "traefik.project_name=${COMPOSE_PROJECT_NAME}"
- "traefik.http.routers.novu-bridge.rule=Host(`bridge-novu.${PHRASEA_DOMAIN}`)"
- "traefik.http.services.novu-bridge.loadbalancer.server.port=4000"
- "traefik.http.services.novu-bridge.loadbalancer.server.port=3000"
extra_hosts:
- api-novu.${PHRASEA_DOMAIN}:${PS_GATEWAY_IP}
- bridge-novu.${PHRASEA_DOMAIN}:${PS_GATEWAY_IP}
Expand Down
10 changes: 8 additions & 2 deletions novu/bridge/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,14 @@ USER 1000

WORKDIR /usr/src/app

COPY --chown=1000:1000 . .
COPY --chown=1000:1000 package.json pnpm-lock.yaml ./

RUN pnpm install --frozen-lockfile

CMD ["pnpm", "dev"]
COPY --chown=1000:1000 . .

ENV NOVU_SECRET_KEY=__defined_me

Check warning on line 26 in novu/bridge/Dockerfile

View workflow job for this annotation

GitHub Actions / Build novu-bridge / build

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "NOVU_SECRET_KEY") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

RUN pnpm build

CMD ["pnpm", "start"]
2 changes: 1 addition & 1 deletion novu/bridge/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"scripts": {
"dev": "next dev --port=4000",
"dev": "next dev --port=3000",
"build": "next build",
"start": "next start",
"lint": "next lint",
Expand Down

0 comments on commit 00e054e

Please sign in to comment.