Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow directories to be scp with the config files #49

Open
WilliamMcCumstie opened this issue Sep 19, 2018 · 2 comments
Open

Allow directories to be scp with the config files #49

WilliamMcCumstie opened this issue Sep 19, 2018 · 2 comments

Comments

@WilliamMcCumstie
Copy link
Contributor

WilliamMcCumstie commented Sep 19, 2018 •
edited
Loading

Before running the command, the contents of the directory containing config.yaml is scp to a temporary directory on the node. The commands is ran with the temp dir as its working directory.

Currently the following library is being used to preform the scp. It does not however support copying directories. This will either have to be done manually, using local, or maybe operations.

I had a look at using the operations however I couldn't get it to work.
@WilliamMcCumstie WilliamMcCumstie mentioned this issue Sep 19, 2018
Closed
@mjtko
Copy link
Member

mjtko commented Sep 19, 2018

Fine for MVP, cos we can just use a tarball for now if necessary to deal with copying directory structure (i.e. script untars on the remote side).

DavidMarchant added a commit that referenced this issue Oct 10, 2018
@DavidMarchant
Add exception for dirs sibling to config.yaml
747438a 
This represents an error as it stands but it won't when issue #49 is
fixed, will need to be altered
Also changed 1 statement to use os.path.join()
@DavidMarchant DavidMarchant mentioned this issue Oct 11, 2018
Merged
@DavidMarchant
Copy link
Contributor

DavidMarchant commented Oct 11, 2018 •
edited
Loading

When this is solved the validation in action preventing config files from having sibling directories will need to be removed
https://github.com/alces-software/adminware/pull/87/files#diff-830c29e01d3cd68bf4ae48a11faee837R53
Ignore this ^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjtko @WilliamMcCumstie @DavidMarchant