begin clearing errors and warning #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 % type-based:
<Qxxx> added,
Qt:: added,
Qyyy::ENUM changed,
QVector overlaods deleted (is alias of QList),
QzzzLiteral are now simply QzzzString,
QFileInfo constructor around paths,
comparison with letters: 'A' (not "A"),
some new methods ("secsSinceEpoch" instead of "time_t", "setEncoding" instead of "setCodec",
...
some explicit casts (5%)
some msvc #pragmas (5%)
logic adjusment File Dialog (3%),
logic correction SQL (7%) (prepared statement placeholders have no API to get them!)
|
For reference:
|
|
Not sure if I want to go the Qt 6 path. Looks like a lot of effort and I expect plenty of side effects. I even don't want to know what the dock window management is doing now. 🙁 |
|
i leave this PR here in draft state not continuing the upgrade for now. |
|
Let's keep this in mind for a future version. Maybe after 2.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
80 % type-based:
added,
Qt:: added,
Qyyy::ENUM changed,
QVector overlaods deleted (is alias of QList),
QzzzLiteral are now simply QzzzString,
QFileInfo constructor around paths,
comparison with letters: 'A' (not "A"),
some new methods ("secsSinceEpoch" instead of "time_t", "setEncoding" instead of "setCodec",
...
some explicit casts (5%)
some msvc #pragmas (5%)
logic adjusment File Dialog (3%),
logic correction SQL (7%) (prepared statement placeholders have no API to get them!)