Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge piqi-ocaml with piqi #73

Open
ivg opened this issue Aug 9, 2022 · 1 comment
Open

Merge piqi-ocaml with piqi #73

ivg opened this issue Aug 9, 2022 · 1 comment

Comments

@ivg
Copy link
Contributor

ivg commented Aug 9, 2022

We started the discussion at ocaml/opam-repository#21947 but let's continue here. Dune works perfectly with monorepos (i.e., repositories that contain several projects under the umbrella of one project). It may even handle vendored code for you. As far as I can tell from the Makefiles, there are already some cross-project depdencies between piqi and piqi-ocaml. Moreover, piqi depends on piqi-ocaml to generate files and piqi-ocaml, depends on piqilib that is provided in piqi. Managing such dependencies without merging two repositories into a single repository is impossible without relying on subpar methods, like installing them side-by-side in the single repository. In addition, even without touching tests and bootstrapping scripts, just merging those repositories together will allow us to use dune-release that fully automates the whole release process. So that in the end, the whole release of three opam packages will be just one keystroke. So, what are your thoughts?

@alavrik
Copy link
Owner

alavrik commented Sep 1, 2022

Hi Ivan, I think this is good idea. Thanks for bringing it up and explaining the benefits.

Historically, I separated the two repositories as I thought there would be more language implementations and I wanted all including OCaml one to depend on piqi explicitly and avoid coupling of changes and releases. But this as you pointed out complicates the logistics for managing all things OCaml. (Piqi only depends on piqi-ocaml for bootstrap, but still separating the repos introduces friction even there).

Let me try moving piqi-ocaml over as the first step and then let's coordinate on further changes. It would be worth bringing things sufficiently up to date wrt dune, sedlex, warnings, etc. I'll find some time early next week.

alavrik added a commit that referenced this issue Sep 5, 2022
Copy as a subdirectory from https://github.com/alavrik/piqi-ocaml

This is the first step in reintegrating it with the main piqi repo to
unify the OCaml codebase and streamline the logistics for furture
maintenance and use by OCaml users.

More contex in #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants