Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should get_params() expose all model parameters? #249

Open
mastoffel opened this issue Sep 27, 2024 · 0 comments
Open

Should get_params() expose all model parameters? #249

mastoffel opened this issue Sep 27, 2024 · 0 comments

Comments

@mastoffel
Copy link
Collaborator

mastoffel commented Sep 27, 2024 •
edited
Loading

Each emulator has a self.model_ attribute which contains the actual model. The question is whether we want get_params to expose the __init__ parameters of self.model_ or of the emulator itself (as it is currently).
@mastoffel mastoffel changed the title get_params() get_params() should expose all model parameters Sep 27, 2024
@mastoffel mastoffel changed the title get_params() should expose all model parameters Should get_params() expose all model parameters? Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mastoffel