Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add support for dark mode #2863

Open
2 of 3 tasks
ddeath opened this issue Oct 28, 2024 · 2 comments
Open
2 of 3 tasks

UI: Add support for dark mode #2863

ddeath opened this issue Oct 28, 2024 · 2 comments

Comments

@ddeath
Copy link
Contributor

ddeath commented Oct 28, 2024

Checklist

  • I've searched the issue queue to verify this is not a duplicate feature request.
  • I've pasted the output of kargo version, if applicable.
  • I've pasted logs, if applicable.

Proposed Feature

It would be nice to support Dark mode. If this is something you would like to have, I can help with it as well.

Motivation

I am developer and I like to live in a cave :D and Kargo is too bright for that. Some browser extensions can do the job but would be nice to have dark mode native support.

Suggested Implementation

antd supports theming so this should not be too difficult to do. However we are missing "User settings" but I saw somewhere in other issue that you want to have User info section similar to ArgoCD so eventually it could sit there

@krancour
Copy link
Member

krancour commented Oct 28, 2024

I like dark mode as well and at some point in the past we had it, or had at least experimented with it. @rbreeze had reported that it was proving to onerous to ensure that every change looked good in both modes and we committed to just light.

I'm open to that decision being re-evaluated by @Marvin9 and defer to his judgement, but if we do it, this is going to be a low-priority enhancement.

@ddeath
Copy link
Contributor Author

ddeath commented Oct 29, 2024

Not perfect but kind of working 1 liner dark mode is this css:

body {
  filter: invert(88%) hue-rotate(180deg);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants