Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make promotion mode more obvious in ui #2778

Open
3 tasks done
kejne opened this issue Oct 18, 2024 · 1 comment
Open
3 tasks done

Make promotion mode more obvious in ui #2778

kejne opened this issue Oct 18, 2024 · 1 comment

Comments

@kejne
Copy link

kejne commented Oct 18, 2024

Checklist

  • I've searched the issue queue to verify this is not a duplicate feature request.
  • I've pasted the output of kargo version, if applicable.
  • I've pasted logs, if applicable.

Kargo version tested: 0.9.1

Proposed Feature

Make freights very easily selectable when promoting. When promoting freight, it should be obvious that you are in promotion mode and that selections at this point is to promote a freight. Other functionality should be hidden during this time to make it clear what is going on.

Motivation

When promoting something currently, you really need to look hard that you're really in promotion-mode. Only a small "cancel" to the right and the text above says that you should select freight to promote. While it clearly has a new text, a nicer UX would be that the context is changed profoundly when the behavior of buttons also changes.

You will get a lot of tool tips when moving over the freight. The regular links are also highlighted, which confuses users that they will go somewhere else during the promotion and adds to the confusion if you are really promoting or not.

Moving cursor over freight when not promoting:
image

Doing the same when promoting:
image
As can be seen these look basically identical.

Suggested Implementation

During promotion, make everything around the freight line darker and highlight the freight line. Links within a freight (like copy commit sha, links to specific artifacts) should not be enabled. No tooltips and no underlining light-up. Instead the entire freight should be clickable to select the promotion only.

@krancour
Copy link
Member

Agreed on most of that... although the tooltips might still be useful in identifying the Freight you're looking for. It would be unfortunate if you had to cancel the promotion workflow to inspect Freight more closely for the sake of identifying a particular one, only to then resume the promotion workflow. But I totally agree on improved visual cues and making the Freight less navigable/interactive during promotion. I have been frequently annoyed that when selecting Freight for promotion, one needs to be quite careful not to click on any UI element within the Freight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants