Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJs 6 Support #99

Open
iamwyza opened this issue May 5, 2018 · 5 comments
Open

RxJs 6 Support #99

iamwyza opened this issue May 5, 2018 · 5 comments

Comments

@iamwyza
Copy link

iamwyza commented May 5, 2018

  • I'm submitting a ...
    [x] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository

  • Do you want to request a feature or report a bug?

bug

  • What is the current behavior?

module can't be used with RxJs v6. (npm update)

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar.

Add module to a Angular 6 environment without rjxs-compat.
Then do npm install/update:

node_modules/ng2-toasty/src/toasty.service.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/Observable"' has no exported member 'Observable'.

  • What is the expected behavior?

module works

  • What is the motivation / use case for changing the behavior?

see above

  • Please tell us about your environment:
  • Angular version: 6.0.0
  • Browser: all
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
@Rzpeg
Copy link

Rzpeg commented May 7, 2018

module can be used with Angular 6, with rxjs-compat installed

@intuitivepixel
Copy link

intuitivepixel commented May 7, 2018

module can be used with Angular 6, with rxjs-compat installed

that is true I can confirm that it works, but are there any plans to update to rxjs 6 anytime soon?

@iamwyza
Copy link
Author

iamwyza commented May 7, 2018

@Rzpeg - Well yes, that can be said of alot of things, but that's a lousy answer. -compat adds alot of bloat and, also, -compat will only work for rxjs 6. rxjs7 will not have a -compat release. (the release notes for 6 stated this). Out of all the modules I presently am using in my app, only this and one other don't properly handle this.

So, the issue stands.

@Rzpeg
Copy link

Rzpeg commented May 7, 2018

This repo looks dead, no activity at all.

I have migrated my project to https://github.com/scttcper/ngx-toastr

@emonney
Copy link

emonney commented Jun 28, 2018

I have ported this library here with angular6 and rxjs6 support. ngx-toasta.
And also with some extra enhancements.

npm install ngx-toasta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants