Great tool!!

[Max-P0wer]

I really love this program! Good job!

I have a few tweaks for you. Please forgive the format/manner in which I'm submitting these. I'm not a programmer, nor, do I really have the skill set to properly participate in open source projects. LOL But, I try really hard to help as much as I can!!

On my particular system, timezone setting is largely ignored. This causes the log files to fill up as it complains everytime the 'date' function is called in php. Apparently, the work around is to put a one-line .htaccess in the dtgraph folder containing this:

php_value date.timezone America/Denver

Obviously, change that for your locale. I don't really this is a bug in your code. I think this is a problem somewhere in php itself, but, I figure it might be a handy tip for your users. (found here: http://php.net/manual/en/function.date-default-timezone-set.php ...look at "Taylor"'s post).

I was also getting an error from line 13 of admin.php:

Undefined variable: PHP_SELF

I found that changing line 13 to the following cleared up the error:

I found that fix here: http://stackoverflow.com/questions/12710803/undefined-variable-php-self
Although, if you read the most highly ranked solution on that page, it recommends not using PHP_SELF at all. I'll leave that bit to you if you decide to change it. ;-)

The last thing I found was that Line colors were being ignored. It turns out that you have to set line properties after putting them on the graph.....which is a bit weird, but, the fix is easy enough. In graph.php at approximately line 266, I added the bits to change the line and mark colors etc (although the marks settings actually seem to work where they were?)

            $graph->Add($plots[$serial]);
            $plots[$serial]->SetColor($color);
            if (isOptionOn($options, 'showMarks')) {
                $plots[$serial]->mark->SetType(MARK_DIAMOND);
                $plots[$serial]->mark->Show();
                $plots[$serial]->mark->SetColor($color);
            }

Then I removed those same bits from the makePlot function as well.

I hope this helps!! Thanks for the great tool!

-Joe

[Max-P0wer]

Oh, I forgot to mention that I discovered the fix for the line color issue here:
http://webdeveloperoddities.blogspot.ca/2010/10/jpgraph-cannot-change-line-colour-or.html

[akomakom]

Joe,

Thanks for your input. For someone who is not a developer, you seem to have
figured out quite a bit.

You are quite right on all counts:

1. Timezone is a local PHP configuration issue. You found one of the
   dozen ways to correct it.
2. $PHP_SELF is a complete screwup. I corrected it on the master branch.
3. The line color thing is a change in a later version of jpgraph that I
   never tested against. I am using the version currently provided with
   Ubuntu LTS repos, which seems to be 1.5.2. I suppose that's ancient.
   Time permitting, I'll look into refactoring it to change the order to this
   (as you pointed out) counter-intuitive way of doing things.

Thanks for your help! I'm most impressed that this thing is still being
used. The renewed interest makes me want to rewrite it in 21st century
manner...

On Sat, Aug 29, 2015 at 5:44 PM, Max-P0wer [email protected] wrote:

Oh, I forgot to mention that I discovered the fix for the line color issue
here:

http://webdeveloperoddities.blogspot.ca/2010/10/jpgraph-cannot-change-line-colour-or.html

—
Reply to this email directly or view it on GitHub
#1 (comment).