From b8cb9463bfdeba33b27ef4fbaf539d27fdcf0da9 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Sat, 27 Feb 2016 17:39:30 +0100 Subject: [PATCH 1/3] Fix mutation errors in some `f` commands For example, `2f` is supposed to open the first link in a new background tab and the second link in the current tab. However, both were opened in background tabs due to accidental mutation. --- extension/lib/commands.coffee | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/extension/lib/commands.coffee b/extension/lib/commands.coffee index 5049c453..6e9fb071 100644 --- a/extension/lib/commands.coffee +++ b/extension/lib/commands.coffee @@ -381,8 +381,9 @@ helper_follow = (name, vim, callback, count = null) -> vim.enterMode('normal') ) -helper_follow_clickable = ({inTab, inBackground}, {vim, count = 1}) -> +helper_follow_clickable = (options, {vim, count = 1}) -> callback = (marker, timesLeft, keyStr) -> + {inTab, inBackground} = options {type, elementIndex} = marker.wrapper isLast = (timesLeft == 1) isLink = (type == 'link') @@ -420,7 +421,7 @@ helper_follow_clickable = ({inTab, inBackground}, {vim, count = 1}) -> return not isLast - name = if inTab then 'follow_in_tab' else 'follow' + name = if options.inTab then 'follow_in_tab' else 'follow' helper_follow(name, vim, callback, count) commands.follow = From fa97e8ceacb4d85d09da13b11346f59e4d37073b Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Sun, 13 Mar 2016 08:15:51 +0100 Subject: [PATCH 2/3] Tweak the issue template --- .github/ISSUE_TEMPLATE.md | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index e8aa62ad..f1d21473 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -10,15 +10,15 @@ Steps to reproduce: 2. 3. -[Description] +Expected result: +Actual result: -| OR, for feature requests: +| OR, for feature requests: -Detailed use case example: -[Description] +Detailed use case example: | ALWAYS include: @@ -29,8 +29,7 @@ Firefox version: OS: Keyboard language: Worked before: -Example URL(s): -- +Example URL(s): | EXAMPLE: @@ -41,9 +40,13 @@ Example URL(s): | 2. Focus the online terminal. | 3. Type something into it. | -| VimFx doesn’t recognize the online terminal as a text input, so instead of -| typing into it I end up activating VimFx commands. A work-around is to use -| Ignore mode. +| Expected reult: VimFx recognizes the terminal as a text input, automatically +| allowing to type into it. +| +| Actual result: Instead of typing into the terminal I end up activating VimFx +| commands. +| +| A work-around is to use Ignore mode. | | VimFx version: 0.11.0 | Firefox version: 43 From 45e9f389ca4ac81f2d01454aa2dc3c656c4d9508 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Sat, 19 Mar 2016 11:10:02 +0100 Subject: [PATCH 3/3] Fix broken link in tools.md --- documentation/tools.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/documentation/tools.md b/documentation/tools.md index 8821a636..aa62cbb1 100644 --- a/documentation/tools.md +++ b/documentation/tools.md @@ -230,5 +230,5 @@ Steps: The idea is to use the contents of `README.md` as the add-on description on addons.mozilla.org. You can print it as HTML by running `gulp readme`. -[versioning guidelines]: CONTRIBUTING_CODE.md#versioning-and-branches +[versioning guidelines]: CONTRIBUTING-CODE.md#versioning-and-branches [valid Firefox versions]: https://addons.mozilla.org/en-US/firefox/pages/appversions/