Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript single line comments cause parse error #49

Open
troyk opened this issue Feb 8, 2012 · 1 comment
Open

javascript single line comments cause parse error #49

troyk opened this issue Feb 8, 2012 · 1 comment

Comments

@troyk
Copy link

troyk commented Feb 8, 2012

Parser pukes on this:

  <script language="javascript">
    $(function(){
      $('#krutmnu a').click(function(e){
        //$('#body').children().hide().filter('#'+$(this).attr('href').replace(/#/,'')+'_panel').toggle(true);
      });
    });
  </script>

But not this:

  <script language="javascript">
    $(function(){
      $('#krutmnu a').click(function(e){
        /* $('#body').children().hide().filter('#'+$(this).attr('href').replace(/#/,'')+'_panel').toggle(true); */
      });
    });
  </script>

It looks like development here has stalled, but of course the great thing with open source is I can fix this myself but I think I'll wait and see if this is covered in the linkedin fork which is supposed to show up soon http://engineering.linkedin.com/frontend/client-side-templating-throwdown-mustache-handlebars-dustjs-and-more

@vybs
Copy link

vybs commented Mar 29, 2012

We avoid using inline scripts in the templates for a lot of good reasons. But certainly a good fix to have.

BTW, we now host our fork on the repo.

https://github.com/linkedin/dustjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants