feat: add Platform#setTabindex() #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnv
reviewed
Oct 17, 2023
src/InputHandlerLayer.ts
Outdated
| @@ -67,11 +67,17 @@ export class InputHandlerLayer { | |||
| view.style.height = size.height + "px"; | |||
| } | |||
|
|
|||
| setViewTabindex(tabindex: number | undefined): void { | |||
There was a problem hiding this comment.
議論:
- 利用者にとって、これを指定する引数は、後方互換性を考えると
undefinedをデフォルト値にせざるを得ない - tabindex の「デフォルト値」は
"0"であるべきに思えるが、ここでundefinedは「tabindexなし」の表現になっているので、辻褄が合わない - 考えられる選択肢:
- (a)
tabindex: number | ""のように明確に「tabindexなし」を表す表現を数値とundefined以外に作る - (b)
tabindex: stringとして全部文字列で受けてしまう
- (a)
- (b) は型的に過剰に広いが、 (a) はかなり見慣れない型付けになり、一長一短
- ここでは (b) を採ることにする
ShinobuTakahashi
approved these changes
Oct 17, 2023
xnv
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このPullRequestが解決する内容
InputHandlerのviewにtabindex: 0を付与します。tabindexを操作するメソッドPlatform#setTabindex()を追加します。