Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A mistake about computing bias term #6

Open
Jun-jie-Huang opened this issue Apr 28, 2019 · 1 comment
Open

A mistake about computing bias term #6

Jun-jie-Huang opened this issue Apr 28, 2019 · 1 comment

Comments

@Jun-jie-Huang
Copy link

Hi, I've implemented a soft-margin SVM with kernel function and I referred to yours. I found there's a problem in your code to compute the bias term in the training process in this line.. Your code compute the by using the SVMPredictor which you set bias to 0. In this way, you compute the term AND use a sign function. But in the SVM algorithm, the sign function is not used in computing the bias term.

@MatrixRanger98
Copy link

Yes. We shouldn't use sign function here. That is a major mistake rather than a bug. I highly suggest correcting it as there are already many webpages on svm quoting this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants