-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for kornshell #769
Comments
What's janky about it? |
It doesn't always work and kornshell has more features than a generic posix shell. We could use these features to improve performance of zoxide in kornshell. Here is the kornshell I use : https://github.com/ksh93/ksh |
Could you elaborate? If there's a bug in the generic POSIX implementation, we should fix that.
What Korn-specific features do you think zoxide should be utilising? Is there any part of zoxide that's running slow on your system? |
The execution time in kornshell is slow. My systtem has 4 cores and 8 threads. (2017 macbook pro 15 inch) |
There's not much to do here, unfortunately:
zoxide is a very light binary, a 2017 MacBook is more than sufficient for it. There may be a one-off slowdown because macOS checks binaries before executing them the first time, but that should not persist. What exactly takes long to execute on your system? |
(Did some work in ksh a while back.) Briefly tested on OpenSUSE tumbleweed. Unable to replicate the problem. I looked through the man page and didn't find any additional hooks other than ➜ ~ ksh --version
version sh (AT&T Research) 93u+ 2012-08-01
➜ ~ uname -a
Linux localhost.localdomain 6.8.1-1-default #1 SMP PREEMPT_DYNAMIC Tue Mar 19 07:32:20 UTC 2024 (d922afa) x86_64 x86_64 x86_64 GNU/Linux
CPU Info
echo "Hello world"
eval "$(zoxide init posix --hook prompt)" |
Agreed, I don't think this issue is actionable. |
zoxide v0.9.5 now officially supports |
Thank You! |
I use this in zsh, but would like it in kornshell as the
is a little janky
The text was updated successfully, but these errors were encountered: