fix: use str length for str instead of length

[mrdgo]

nushell won't start as long as you use length.

[1 2 3 4] | length

works.

"hello world" | str length

works.

Different permutations don't.

[mati865]

This won't work, I have tried the same but it fails when trying to use zoxide:

❯ z target
Error: nu::shell::type_mismatch

  × Type mismatch during operation.
    ╭─[/home/mateusz/.zoxide.nu:27:1]
 27 │   let arg0 = ($rest | append '~').0
 28 │   let path = if (($rest | str length) <= 1) and ($arg0 == '-' or ($arg0 | path expand | path type) == dir) {
    ·                  ──────────┬───────── ─┬ ┬
    ·                            │           │ ╰── int
    ·                            │           ╰── type mismatch for operator
    ·                            ╰── list<int>
 29 │     $arg0
    ╰────

[maxim-uvarov]

@mati865 I believe this is a bug of nushell 0.83.0 (check it here nushell/nushell#9809)

Otherwise it should work.

[fdncred]

A hack for this, until we fix the bug, to get people up and running is changing

def-env __zoxide_z [...rest:string]

to

def-env __zoxide_z [...rest]

and do the same for __zoxide_zi

[mati865]

@mati865 I believe this is a bug of nushell 0.83.0 (check it here nushell/nushell#9809)

Otherwise it should work.

Yup, that's why I have mentioned it in referenced item.

[mrdgo]

yes I agree, I faced the same issue :) Seemed to work at first

[mrdgo]

updated fix to temporary fix.

[fdncred]

fwiw, I'd run with the "temporary fix" for now. I'm not sure how long it'll be to fix it the "right" way. We can do another PR here when ...rest: string works again.

[asim215]

I fix it by another way.
See #595 .

[amtoine]

hello there from Nushell 👋 😋

so yeah str length is not a drop in replacement for length in that case, because $rest is not a string but a list<string>, which can be seen with a describe as in nushell/nushell#9720 (comment) 👍

this was a bug with how $rest was passed around and has been fixed upstream in nushell/nushell#9816 😌
should be available soon in a patch release 😊

[ajeetdsouza]

That's good news! In that case, I think it would be better to wait for the patch release rather than release a hack here.

[amtoine]

That's good news! In that case, I think it would be better to wait for the patch release rather than release a hack here.

we're working on it... ♻️
i'd say the best and safest is to keep those kind of PRs opened and ready, just in case, and all stay in touch. how's that sound? 😇

[ajeetdsouza]

This seems to be fixed in Nushell, so I'm closing this. Thanks!