diff --git a/.github/workflows/deploy-frontend-pr-previews.yml b/.github/workflows/deploy-frontend-pr-previews.yml index 80011507be..27a8481c0b 100644 --- a/.github/workflows/deploy-frontend-pr-previews.yml +++ b/.github/workflows/deploy-frontend-pr-previews.yml @@ -119,10 +119,10 @@ jobs: username: _json_key password: ${{ secrets.GCP_SA_CREDENTIALS }} - - name: Build and Push Docker Image + - name: Build and Push Docker Image run: | cd netmanager/ - docker build -t ${{ env.REGISTRY_URL }}/${{ env.PROJECT_ID }}/pr-previews/netmanager-pr-previews:${{ github.sha }} ./ + docker build --tag ${{ env.REGISTRY_URL }}/${{ env.PROJECT_ID }}/pr-previews/netmanager-pr-previews:${{ github.sha }} ./ docker push ${{ env.REGISTRY_URL }}/${{ env.PROJECT_ID }}/pr-previews/netmanager-pr-previews:${{ github.sha }} docker tag ${{ env.REGISTRY_URL }}/${{ env.PROJECT_ID }}/pr-previews/netmanager-pr-previews:${{ github.sha }} ${{ env.REGISTRY_URL }}/${{ env.PROJECT_ID }}/pr-previews/netmanager-pr-previews:latest docker push ${{ env.REGISTRY_URL }}/${{ env.PROJECT_ID }}/pr-previews/netmanager-pr-previews:latest @@ -149,7 +149,7 @@ jobs: --platform managed \ --region ${{ secrets.REGION }}) echo "url=${service_url}" >>$GITHUB_OUTPUT - + netmanager-pr-comment: name: netmanager-preview-link-comment if: needs.check.outputs.run_netmanager == 'true' diff --git a/.github/workflows/deploy-frontends-to-staging.yml b/.github/workflows/deploy-frontends-to-staging.yml index 9ee6c0c215..45eeb7ab21 100644 --- a/.github/workflows/deploy-frontends-to-staging.yml +++ b/.github/workflows/deploy-frontends-to-staging.yml @@ -131,16 +131,6 @@ jobs: - name: Create .env file run: gcloud secrets versions access latest --secret="sta-env-netmanager" > netmanager/.env - - - name: NPM Setup and Build - uses: actions/setup-node@v3 - with: - node-version: "12" - - run: | - cd netmanager/ - npm install - CI=false npm run build - - name: Login to GCR uses: docker/login-action@v2 with: