Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtraPipPackages are supported for 'airflow' values node, not 'scheduler' #888

Open
3 of 4 tasks
chrisdonlan opened this issue Sep 18, 2024 · 1 comment
Open
3 of 4 tasks
Labels
kind/docs kind - documentation

Comments

@chrisdonlan
Copy link

Checks

Description

The documentation generated 5 months ago indicates you can modify airflow in the scheduler with extraPipPackages rather than "all" airflow pods by including the scheduler section of values.yaml:

# values.yaml
scheduler:
  extraPipPackages:
    - airflow-provider-foo-bar
    ...

However, that does not work. My mistake here was thinking that meant that extraPipPackages had been deprecated, and I needed to consider other methods such as supporting my own airflow image or adding an init scheme.

After a significant amount of time, I decided to try some of the other nodes to see if the schema would allow extraPipPackages there (in case it was a bug or mistake). The result was good:

# passes schema checks
airflow:
  extraPipPackages:
    - airflow_declarative 

airflow: seems like the values node least likely to be supported if a child item is unsupported, since it is the most comprehensive option. But from a testing perspective, it makes sense: it is the first thing you'd try when QA'ing, and the last thing you'd try when using for the first time.

I am not sure whether only scheduler has this option disabled, or everything other than airflow has the option disabled. I can say it took a non trivial amount of time for me to decide the other options weren't worth it and start trying things on the off chance the docs weren't correct.

Are you willing & able to help?

  • I am able to submit a PR!
  • I can provide feedback!
@chrisdonlan chrisdonlan added the kind/docs kind - documentation label Sep 18, 2024
@thesuperzapper
Copy link
Member

thesuperzapper commented Oct 15, 2024

@chrisdonlan I'm confused, what are you having problems with?

I just tested by setting the following values on version 8.9.0 of the chart, and it worked fine:

scheduler:
  extraPipPackages:
    - "tailscale==0.6.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs kind - documentation
Projects
None yet
Development

No branches or pull requests

2 participants