Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to upgrade the airflow cluster while keep my airflow jobs running with no downtime #839

Open
2 of 4 tasks
zeddit opened this issue Mar 22, 2024 · 3 comments
Open
2 of 4 tasks
Labels
kind/enhancement kind - new features or changes

Comments

@zeddit
Copy link

zeddit commented Mar 22, 2024

Checks

Motivation

It's a common case for upgrading the airflow, e.g. installing a new 3rd party provider's package and upgrade the airflow major version.
All these processes above will involve an upgrade to the airflow image running on k8s. which needs to shutdown the related pods and start a new one with the new version.

And this kind of shutdowns will make the jobs running on top of airflow stopped and may be not recovered because it will stop at a middle place in DAG and marked as success.

How to make airflow helm upgrade do not influence the jobs running and keep the result of job executions correct?

Implementation

No response

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!
@zeddit zeddit added the kind/enhancement kind - new features or changes label Mar 22, 2024
@thesuperzapper
Copy link
Member

@zeddit Because changing the airflow image will always require a restart of all worker pods, your only options are something like:

  1. design your DAGs so they are able to recover safely if they are interrupted (which is a good idea, because servers crash, and other things can happen, even when you are not updating)
  2. if you want to prevent Kubernetes from restarting a worker that has any running tasks, you can use the workers.celery.gracefullTermination values, but this only affects restarts caused by a StatefulSet rollout. (Also some Kubernetes providers, put a limit on how long gracefullTerminationPeriod can be, e.g. GKE limits it to 10 minutes)

@zeddit
Copy link
Author

zeddit commented May 14, 2024

@thesuperzapper really appreciate for your reply, and I learned a lot.

could I understand that as, if I use KubernetesExecutor, only worker pods will be restarted and they may restart at any time point by being terminated. While other pods like database, scheduler, ui will not restart if I updated the airflow image like apache-airflow:python3.8. and this is the regular update.

what if I need to upgrade scheduler and other components, will that break the correctness of jobs if I followed the dag principle stated above? great thanks

@ahdeanlau
Copy link

having same concern on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement kind - new features or changes
Projects
None yet
Development

No branches or pull requests

3 participants