Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling gitsync and PVC should work #741

Closed
2 tasks done
ekdeveloper opened this issue May 11, 2023 · 1 comment
Closed
2 tasks done

Enabling gitsync and PVC should work #741

ekdeveloper opened this issue May 11, 2023 · 1 comment
Labels
kind/enhancement kind - new features or changes status/duplicate status - this issue or pull request already exists

Comments

@ekdeveloper
Copy link

ekdeveloper commented May 11, 2023

Checks

Chart Version

8.7.0

Kubernetes Version

NA

Helm Version

8.7.0

Description

airflow doc says the both gitsync and pvc can be enabled
https://airflow.apache.org/docs/helm-chart/stable/manage-dags-files.html#mounting-dags-using-git-sync-sidecar-with-persistence-enabled

https://github.com/apache/airflow/blob/97215822f90cac274e92e642fcd724cc940fe0eb/chart/templates/dag-processor/dag-processor-deployment.yaml#L135

however there is a validation check to prevent this
https://github.com/airflow-helm/charts/blob/f5c2f0cd617982c642789cf66fdef48453f84e67/charts/airflow/templates/_helpers/validate-values.tpl#LL122C1-L122C1

Relevant Logs

No response

Custom Helm Values

No response

@ekdeveloper ekdeveloper added the kind/bug kind - things not working properly label May 11, 2023
@thesuperzapper
Copy link
Member

@ekdeveloper the docs you are referencing are for a different helm chart. This helm chart (the User-Community one) is planning to implement support for having both git-sync and PVC persistence soon (see #283), but this change has not yet been merged, hence the values-validation which prevents it for now.

@thesuperzapper thesuperzapper closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
@thesuperzapper thesuperzapper added status/duplicate status - this issue or pull request already exists kind/enhancement kind - new features or changes and removed kind/bug kind - things not working properly labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement kind - new features or changes status/duplicate status - this issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants