add airflow.extraEnvFrom value

[mattaltberg]

Checks

• I have checked for existing issues.

Motivation

Currently, I have Configmaps and Secrets set up for my cluster. The problem is, to access all of these as environment variables, I need to manually add each a separate env entry, which is very tedious. By adding envFrom as a field to values.yml, I can use the envFrom field to my advantage.

Implementation

Add this block:

{{- if .Values.airflow.extraEnvFrom }}
{{ toYaml .Values.airflow.extraEnvFrom }}
{{- end }}

to pods.tpl after Line 406 (in the block where airflow.envFrom is defined

Are you willing & able to help?

• I am able to submit a PR!
• I can help test the feature!

[thesuperzapper]

@mattaltberg I still remain quite against an airflow.extraEnvFrom value, for the same reasons I raised a long time ago in #117 (comment).

The gist of it is that adding this feature will make people try and set airflow configs inside Secrets/ConfigMaps rather than airflow.config, without realizing that pods don't receive environment variable updates from Secrets/Configmaps until they are restarted.

[albertjmr]

@thesuperzapper is the concern about pods not restarting after config/secret updates still current? The link you posted doesn't seem to point at a heading in the documentation anymore. I wonder if this has changed on recent k8s versions?

UPDATE:
I've now just made a quick test (k8s v1.28) and it still seems to be the case that pods aren't restarted after secrets/config are updated...

Although I'm still curious about the original link to the documentation, I wonder why it has been removed?