chore: lint fixes

airbyte/_executors/python.py

@@ -10,7 +10,7 @@
 from typing import TYPE_CHECKING, Literal
 
 from overrides import overrides
-from rich import print
+from rich import print  # noqa: A004  # Allow shadowing the built-in
 
 from airbyte import exceptions as exc
 from airbyte._executors.base import Executor

airbyte/_executors/util.py

@@ -8,7 +8,7 @@
 import requests
 import yaml
 from requests import HTTPError
-from rich import print
+from rich import print  # noqa: A004  # Allow shadowing the built-in
 
 from airbyte import exceptions as exc
 from airbyte._executors.declarative import DeclarativeExecutor

airbyte/_util/temp_files.py

@@ -23,7 +23,7 @@ def as_temp_files(files_contents: list[dict | str]) -> Generator[list[str], Any,
     try:
         for content in files_contents:
             use_json = isinstance(content, dict)
-            temp_file = tempfile.NamedTemporaryFile(
+            temp_file = tempfile.NamedTemporaryFile(  # noqa: SIM115  # Avoiding context manager
                 mode="w+t",
                 delete=False,
                 encoding="utf-8",

airbyte/_writers/jsonl.py

@@ -35,7 +35,7 @@ def _open_new_file(
         """Open a new file for writing."""
         return cast(
             IO[str],
-            gzip.open(
+            gzip.open(  # noqa: SIM115  # Avoiding context manager
                 file_path,
                 mode="wt",
                 encoding="utf-8",

airbyte/cloud/workspaces.py

@@ -215,10 +215,10 @@ def _deploy_connection(
         source_id: str
         if isinstance(source, Source):
             selected_streams = selected_streams or source.get_selected_streams()
-            if source._deployed_source_id:  # noqa: SLF001
-                source_id = source._deployed_source_id  # noqa: SLF001
-            else:
-                source_id = self._deploy_source(source)
+            source_id = (
+                source._deployed_source_id  # noqa: SLF001  # Access to non-public API
+                or self._deploy_source(source)
+            )
         else:
             source_id = source
             if not selected_streams:

airbyte/secrets/config.py

@@ -77,6 +77,6 @@ def disable_secret_source(source: SecretManager | SecretSourceEnum) -> None:
         return
 
     # Else, remove by name
-    for s in _SECRETS_SOURCES:
+    for s in list(_SECRETS_SOURCES).copy():
         if s.name == str(source):
             _SECRETS_SOURCES.remove(s)

airbyte/shared/sql_processor.py

@@ -500,12 +500,13 @@ def _get_temp_table_name(
         if not batch_id:
             batch_id = str(ulid.ULID())
 
-        if len(batch_id) > 9:
-            # Use the first 6 and last 3 characters of the ULID. This gives great uniqueness while
-            # limiting the table name suffix to 10 characters, including the underscore.
-            suffix = f"{batch_id[:6]}{batch_id[-3:]}"
-        else:
-            suffix = batch_id
+        # Use the first 6 and last 3 characters of the ULID. This gives great uniqueness while
+        # limiting the table name suffix to 10 characters, including the underscore.
+        suffix = (
+            f"{batch_id[:6]}{batch_id[-3:]}"
+            if len(batch_id) > 9  # noqa: PLR2004  # Allow magic int value
+            else batch_id
+        )
 
         # Note: The normalizer may truncate the table name if the database has a name length limit.
         # For instance, the Postgres normalizer will enforce a 63-character limit on table names.

airbyte/sources/base.py

@@ -9,7 +9,7 @@
 from typing import TYPE_CHECKING, Any, Literal
 
 import yaml
-from rich import print
+from rich import print  # noqa: A004  # Allow shadowing the built-in
 from rich.syntax import Syntax
 
 from airbyte_protocol.models import (

airbyte/types.py

@@ -1,3 +1,4 @@
+# noqa: A005  # Allow shadowing the built-in 'types' module
 # Copyright (c) 2023 Airbyte, Inc., all rights reserved.
 
 """Type conversion methods for SQL Caches."""
@@ -7,7 +8,7 @@
 from typing import cast
 
 import sqlalchemy
-from rich import print
+from rich import print  # noqa: A004  # Allow shadowing the built-in
 
 
 # Compare to documentation here: https://docs.airbyte.com/understanding-airbyte/supported-data-types

airbyte/validate.py

@@ -15,7 +15,7 @@
 from pathlib import Path
 
 import yaml
-from rich import print
+from rich import print  # noqa: A004  # Allow shadowing the built-in
 
 import airbyte as ab
 from airbyte import exceptions as exc