Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username password should not be checked into git #9

Open
Ameya05 opened this issue Jan 31, 2017 · 2 comments
Open

Username password should not be checked into git #9

Ameya05 opened this issue Jan 31, 2017 · 2 comments
Labels
bug
Milestone
Phase 1: HA/LB fo...

Comments

@Ameya05
Copy link
Member

Ameya05 commented Jan 31, 2017

Docker username password should be tokenized via Travis-CI or Encrypted perhaps instead of being present in the code commits on git

https://github.com/airavata-courses/spring17-laravel-portal/blob/develop/scripts/install.sh
@Ameya05 Ameya05 added the bug label Jan 31, 2017
@Ameya05 Ameya05 self-assigned this Jan 31, 2017
Ameya05 added a commit that referenced this issue Jan 31, 2017
@Ameya05
#9 Using Tokens configured in Travis-CI
473ee81
Ameya05 added a commit that referenced this issue Jan 31, 2017
@Ameya05
Revert "#9 Using Tokens configured in Travis-CI"
6844590 
This reverts commit 473ee81.
@Ameya05
Copy link
Member Author

Ameya05 commented Jan 31, 2017

Didnt work using tokens configured in Travis-CI

Might have to

  1. Encrypt password
    or
  2. Use token Replacement scripts

@tilaks26
Copy link
Contributor

I did try to create a .env file to store passwords. But it didn't seem to work as I expected. Can we remove read permissions to the script? We are anyway using it only to deploy the files, right?

mjaglan pushed a commit that referenced this issue Feb 1, 2017
@Ameya05
Revert "#9 Using Tokens configured in Travis-CI"
588f3a2 
This reverts commit 473ee81.
mjaglan pushed a commit that referenced this issue Feb 1, 2017
@Ameya05
Revert "#9 Using Tokens configured in Travis-CI"
d978fa1 
This reverts commit 473ee81.
@Ameya05 Ameya05 removed their assignment Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Phase 1: HA/LB for Laravel Portal
Development

No branches or pull requests
2 participants
@tilaks26 @Ameya05