New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project 1 Feedback: Team Neo #31

Open

shanki07 opened this issue Feb 10, 2022 · 1 comment

shanki07 commented Feb 10, 2022

Hello Team,

Congratulations on crushing the first milestone. Really liked your project and learned a lot while reviewing the code.

Here are my two cents:

You can use Pyart graph.RadarMapDisplay method to use draw map in your plots, you have to add one more dependency cartopy for this to work.
You can use the docker hub to store your docker images which will be faster for others to run the docker image.
For your overall project instead of running all docker images independently you can use docker-compose for others to test your project.

Regards,
Shashank
Team Neo

Contributor

anbadrin commented Feb 10, 2022

Thank you so much for the review and some good suggestions. We will try to incorporate the changes in the next project milestone.

shanki07 changed the title ~~Project 1 Feedback~~ Project 1 Feedback: Team Neo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment